feat: Implement AbstractLattice and initial GeneralLattice #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yutuer21,
Following your guidance and the excellent framework you provided, I've created this initial PR to establish the foundation for the new lattice module for my OSPP project.
Key Contributions:
AbstractLattice
Base Class: Implemented the complete skeleton for the abstract base class, defining the core API for all future lattice structures.GeneralLattice
Initial Implementation: Provided a preliminary, functional version ofGeneralLattice
that can be instantiated from user-defined coordinates and identifiers.show()
method toGeneralLattice
for visualizing the lattice sites, which I have tested locally.This PR sets the stage for implementing more complex periodic lattices next. Thank you for reviewing!