Skip to content

WIP: Revert "End of round callback adjustment (#1568)" #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teoparvanov wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

WIP: Revert "End of round callback adjustment (#1568)" #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65dc0f6
Revert "End of round callback adjustment (#1568)"
Apr 30, 2025
12393e8
Merge branch 'develop' into revert-end-of-round-callback-adjustment
payalcha Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions openfl/component/aggregator/aggregator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,17 +1169,17 @@ def _end_of_round_check(self):
# Once all of the task results have been processed
self._end_of_round_check_done[self.round_number] = True

# End of round callbacks.
# todo handle case when aggregator restarted before callback was successful
self.callbacks.on_round_end(self.round_number, logs)

# Save the latest model
if not self.assigner.is_task_group_evaluation():
logger.info("Saving round %s model...", self.round_number)
self._save_model(self.round_number, self.last_state_path)
else:
logger.info("Skipping model save for round %s in evaluation mode.", self.round_number)

# End of round callbacks.
# todo handle case when aggregator restarted before callback was successful
self.callbacks.on_round_end(self.round_number, logs)

self.round_number += 1

# resetting stragglers for task for a new round
Expand All @@ -1192,8 +1192,6 @@ def _end_of_round_check(self):
# TODO This needs to be fixed!
if self._time_to_quit():
logger.info("Experiment Completed. Cleaning up...")
# End of experiment callbacks.
self.callbacks.on_experiment_end()
else:
logger.info("Starting round %s...", self.round_number)
# https://github.com/securefederatedai/openfl/pull/1195#discussion_r1879479537
Expand Down
Loading