fix: respect chibi's configured default model#45
Merged
Conversation
Previously buildInput never passed a model to chibi-json, so any model set via AgentConfig (including the hardcoded adapter default) was silently ignored. Now model flows through via config.model per chibi's protocol, and when no model is specified chibi falls back to the user's config.toml default rather than receiving an override.
emesal
force-pushed
the
fix/chibi-model-default
branch
from
54f0c05 to
f06fd02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildInputinchibi-harness.tsnever passed model tochibi-json, soAgentConfig.modelwas silently ignored for all chibi invocationsconfig: { model }per chibi's JSON protocol when a model is explicitly setconfigis omitted entirely so chibi falls back to the user's~/.chibi/config.tomldefaultNavigatorAdapterOptions.modelJSDoc to accurately describe the per-harness default behaviourTest plan
autonav query my-nav "question" --harness chibiwith no model override — chibi uses its configured defaultautonav query my-nav "question" --harness chibiwith model set in nav'sconfig.json— that model is forwarded to chibi