Skip to content

Comments

fix(memento): create one PR per iteration instead of one at end#48

Open
terraboops wants to merge 1 commit intomainfrom
fix/memento-pr-per-iteration
Open

fix(memento): create one PR per iteration instead of one at end#48
terraboops wants to merge 1 commit intomainfrom
fix/memento-pr-per-iteration

Conversation

@terraboops
Copy link
Owner

Summary

  • Each memento iteration now gets its own worktree/branch forked from the default branch, with independent push + PR creation
  • Removes the broken post-loop single-PR logic that was never reached
  • Adds graceful SIGINT handling (first Ctrl+C finishes current iteration, second hard-exits)

Test plan

  • npx tsc --noEmit — no new type errors in modified files
  • autonav memento <dir> <nav> --pr --max-iterations 2 — 2 branches pushed, 2 PRs created
  • autonav memento <dir> <nav> --pr --max-iterations 1 — single iteration, one PR
  • autonav memento <dir> <nav> (no --pr) — iterations run normally, no push/PR
  • Ctrl+C mid-loop — current iteration finishes cleanly

Previously --pr created a single worktree/branch at iteration 1 and
attempted one PR after the loop exited, which often never happened.

Now each iteration gets its own branch forked from the default branch,
making PRs independently reviewable and mergeable. Also adds graceful
SIGINT handling so Ctrl+C finishes the current iteration before exiting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant