Skip to content

feat: Add support for subnet_configuration on VPC endpoints #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

sassdavid
Copy link
Contributor

Description

This PR introduces the ability to configure subnet_configuration for the aws_vpc_endpoint resource.
Terraform VPC Endpoint Resource

Motivation and Context

Fixes #1163

Breaking Changes

Since this is a new feature, it does not affect backward compatibility. No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@sassdavid
Copy link
Contributor Author

Sorry for tagging you directly @antonbabenko, could you please check my PR?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 31, 2025
@sassdavid
Copy link
Contributor Author

I think it's still not stale, it's just that no one has reviewed it yet.

@github-actions github-actions bot removed the stale label Apr 1, 2025
@bryantbiggs bryantbiggs changed the title feat: Support subnet_configuration in aws_vpc_endpoint resource feat: Add support for subnet_configuration on VPC endpoints Apr 21, 2025
@bryantbiggs bryantbiggs merged commit 507193e into terraform-aws-modules:master Apr 21, 2025
20 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 21, 2025
## [5.21.0](v5.20.0...v5.21.0) (2025-04-21)

### Features

* Add support for `subnet_configuration` on VPC endpoints ([#1164](#1164)) ([507193e](507193e))
@antonbabenko
Copy link
Member

This PR is included in version 5.21.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support subnet_configuration in aws_vpc_endpoint resource
3 participants