Skip to content

fix(mysql): error 'backup retention should be > transaction log retention' on mysql replica #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(mysql): error 'backup retention should be > transaction log retention' on mysql replica #785

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
183384d
fix(mysql): Setup retained_backups base on transaction_log_retention_…
diablo02000 Oct 30, 2025
59ee7e3
Merge branch 'main' into fix/backup_retention_settings_on_replica
imrannayer Nov 5, 2025
c7920b4
Merge branch 'main' into fix/backup_retention_settings_on_replica
diablo02000 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/mysql/read_replica.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ resource "google_sql_database_instance" "replicas" {
content {
binary_log_enabled = lookup(backup_configuration.value, "binary_log_enabled", null)
transaction_log_retention_days = lookup(backup_configuration.value, "transaction_log_retention_days", null)
backup_retention_settings {
Copy link
Collaborator

@imrannayer imrannayer Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diablo02000 can we use TF validation for variable to make sure it is correct value? Changing values in code is not a good experience.

Copy link
Contributor Author

@diablo02000 diablo02000 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback @imrannayer. What do you have in mind ? Allow only value greater that 7 for transaction_log_retention_days ?

Copy link
Collaborator

@imrannayer imrannayer Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes validate in variable.

retained_backups = lookup(backup_configuration.value, "transaction_log_retention_days", 0) > 7 ? lookup(backup_configuration.value, "transaction_log_retention_days") + 1 : null
retention_unit = "COUNT"
}
}
}

Expand Down