debug.traceback does not handle coroutines#182
Open
brandonbloom wants to merge 1 commit intoterralang:masterfrom
Open
debug.traceback does not handle coroutines#182brandonbloom wants to merge 1 commit intoterralang:masterfrom
brandonbloom wants to merge 1 commit intoterralang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Pull request is broken. Only providing the patch for discussion.
See https://www.lua.org/manual/5.1/manual.html#pdf-debug.traceback - The override of debug.traceback in terralib does not respect the thread parameter.
You get something like this:
Compare to Lua:
I tried to fix the definition of debug.traceback in terralib, but the obvious solution produced 'error in error handling' for some non-obvious reason. I'll take another look at it soon if you don't have an idea offhand.