Track start offset and whitespace start offset for lexer#690
Open
norcalli wants to merge 1 commit intoterralang:masterfrom
Open
Track start offset and whitespace start offset for lexer#690norcalli wants to merge 1 commit intoterralang:masterfrom
norcalli wants to merge 1 commit intoterralang:masterfrom
Conversation
This makes it possible to get more accurate information for extracting out tokens from the source
Author
|
For instance without this change it would be impossible to get the end of the token since it would be defined by the next token's offset, which happens after skipping whitespace and comments. |
Member
|
Is there an easy way to add a short test case to sanity check this is doing what you expect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to get more accurate information for extracting out
tokens from the source
I'm using this to do
dbgandexpectstyle testing where I can modifysource in place with snapshot tests