Add hono dependency to @terrazzo/cli#753
Open
mrginglymus wants to merge 1 commit intoterrazzoapp:mainfrom
Open
Add hono dependency to @terrazzo/cli#753mrginglymus wants to merge 1 commit intoterrazzoapp:mainfrom
mrginglymus wants to merge 1 commit intoterrazzoapp:mainfrom
Conversation
@hono/node-server has a peer dependency on hono; in this use case it feels not unreasonable for @terrazzo/cli to provide this dependency.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@hono/node-server has a peer dependency on hono; in this use case it feels not unreasonable for @terrazzo/cli to provide this dependency.
Alternative approaches would be making
honoa peer dep of@terrazzo/cli, or making@hono/node-serveran optional peer dep with a lazy import so that those not usinglabdon't need to install it