Do not provide listPermutations API for complex resolvers#754
Open
mrginglymus wants to merge 4 commits intoterrazzoapp:mainfrom
Open
Do not provide listPermutations API for complex resolvers#754mrginglymus wants to merge 4 commits intoterrazzoapp:mainfrom
mrginglymus wants to merge 4 commits intoterrazzoapp:mainfrom
Conversation
|
mrginglymus
force-pushed
the
no-complex-list-permutations
branch
from
b77f880 to
4858513
Compare
1 task
mrginglymus
force-pushed
the
no-complex-list-permutations
branch
from
ab203f3 to
428e155
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
listPermutationspotentially lethal - add safety checks #752Obviously we should provide a way of configuring the limit, but this seems like the safest way of doing it. It's a breaking change, but at least it's a visible breaking change rather than invisibly throwing an error or returning
[].