Use the next power of 2 for default_bucket_count#199
Open
ArekSredzki wants to merge 1 commit intoteslamotors:mainfrom
Open
Use the next power of 2 for default_bucket_count#199ArekSredzki wants to merge 1 commit intoteslamotors:mainfrom
ArekSredzki wants to merge 1 commit intoteslamotors:mainfrom
Conversation
This allows the compiler to optimize the modulo operation into a bitwise and.
Bobobalink
reviewed
Jul 10, 2025
Contributor
Bobobalink
left a comment
There was a problem hiding this comment.
I avoided doing this at first because I was afraid of it causing a large amount of unexpected space overhead, though I agree that it's a good change for runtime reasons.
Do you have any profiling data to show that this is really meaningful? I would be curious to see if the compiler can do other tricks to make modulo faster even for non-powers of two, since this is definitely a compile-time constant.
Collaborator
|
Windows tests are failing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the compiler to optimize the modulo operation into a bitwise and.