Docs: Annotate ModuleTemp fields as double in proto#434
Open
JuanPS999 wants to merge 1 commit intoteslamotors:mainfrom
Open
Docs: Annotate ModuleTemp fields as double in proto#434JuanPS999 wants to merge 1 commit intoteslamotors:mainfrom
JuanPS999 wants to merge 1 commit intoteslamotors:mainfrom
Conversation
|
Can confirm, these values are in 0.5 increments. I've updated my records to reflect this so thanks @JuanPS999 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DescriptionAdded clarification comments to
ModuleTempMin(ID 31) andModuleTempMax(ID 29) inprotos/vehicle_data.proto.As reported in the related issue, the official documentation lists these fields as
Integer, but actual telemetry data from vehicles returnsdouble(floating point) values. This update documents the discrepancy directly in the source of truth to assist developers integrating with the API.Fixes #428
Type of change:
Checklist: