Skip to content

Allow for false and zero field values to be re-initialized correctly #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juancstlm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow for false and zero field values to be re-initialized correctly #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/FormController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,9 +809,10 @@ export class FormController {
// Initialize value if needed
// If we already have value i.e "saved"
// use that ( it was not removed on purpose! )
// including false and 0 since they are values
// Otherwise use the fields initial value
if (
!this.getValue(name) &&
(this.getValue(name) == null || this.getValue(name) == undefined) &&
Copy link
Contributor

@robin-ambachtsheer robin-ambachtsheer Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for the OR clause as undefined already equals null

Copy link
Collaborator

@joepuzzo joepuzzo Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed please make that change

meta.current.initialValue != null &&
(meta.current.initializeValueIfPristine ? this.state.pristine : true)
) {
Expand Down