Open
Conversation
Fixes the dispatcher retransmission logic so that the dispatcher remembers if one of its attempts might have succeeded (even if it never received a response from the vehicle). Categorizes an HTTP 503 code as a possible success, since the server may return this status code if it relays a command to a vehicle but does not hear back.
sethterashima
force-pushed
the
fix-503-and-retry
branch
2 times, most recently
from
fcad171 to
87bb114
Compare
The OpenTrunk method was implemented as an alias for ActuateTrunk, but the commands have different meanings in vehicles with powered trunks and vehicles without. The implementations are now correct, and the proxied `actuate_trunk` invokes ActuateTrunk, leaving its behavior unchanged.
sethterashima
force-pushed
the
fix-503-and-retry
branch
from
87bb114 to
30f7b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue.
Fixes # (issue)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: