Skip to content

Add option to select hci adapter#389

Merged
sethterashima merged 1 commit intoteslamotors:mainfrom
Lenart12:set-hci
Apr 11, 2025
Merged

Add option to select hci adapter#389
sethterashima merged 1 commit intoteslamotors:mainfrom
Lenart12:set-hci

Conversation

@Lenart12
Copy link
Contributor

@Lenart12 Lenart12 commented Apr 8, 2025

Description

In this PR I implement the proposed changes in #373, but without actually switching bluetooth library. This is done so we can prepare library for the backing bluetooth library switch (if it ever happens). Along the way we also got some of the same bonuses that are mentioned in that PR.

Mainly:

Tested with RPI 4B+

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

@pkuehnel
Copy link

pkuehnel commented Apr 9, 2025

Can you please update the docs as well? There are so many undocumendet changes, e.g.

  • Scan for vehicle, instead of sending a command
  • Timeouts for vehicle scan/command execution

@Lenart12
Copy link
Contributor Author

Lenart12 commented Apr 9, 2025

Im confused, there was no changes to any timeout logic. Which parts are you refering to? Maybe your first item is refering to the examples/ble utillity, which has updated docs in regards to -scan-only switch. For the second item, i dont know.

@sethterashima sethterashima merged commit 058ee32 into teslamotors:main Apr 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants