Skip to content

Exposed log package to control level from apps#429

Open
lmartorella wants to merge 1 commit intoteslamotors:mainfrom
lmartorella:fix/logger-api
Open

Exposed log package to control level from apps#429
lmartorella wants to merge 1 commit intoteslamotors:mainfrom
lmartorella:fix/logger-api

Conversation

@lmartorella
Copy link
Contributor

Description

When using the library as a package (like in the ble example), it is not possible to increase the log verbosity of the internal operations for debug.

It seems safe, since the logger package doesn't expose anything critical for the project. The SetLevel is what is required exactly.

The alternative is to expose such SetLevel from another package that is already public. However the current architecture doesn't offer a clear point in which this can be done.

Fixes # (issue)

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

@sethterashima
Copy link
Collaborator

I agree that the logging system needs improvements. But I'd prefer to have a more comprehensive change to a standardized structured logging interface; changes becomes much more difficult once we start exporting methods, and so it's something we should get right the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants