Exposed log package to control level from apps#429
Open
lmartorella wants to merge 1 commit intoteslamotors:mainfrom
Open
Exposed log package to control level from apps#429lmartorella wants to merge 1 commit intoteslamotors:mainfrom
lmartorella wants to merge 1 commit intoteslamotors:mainfrom
Conversation
a1424ec to
63d2359
Compare
Collaborator
|
I agree that the logging system needs improvements. But I'd prefer to have a more comprehensive change to a standardized structured logging interface; changes becomes much more difficult once we start exporting methods, and so it's something we should get right the first time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the library as a package (like in the
bleexample), it is not possible to increase the log verbosity of the internal operations for debug.It seems safe, since the logger package doesn't expose anything critical for the project. The
SetLevelis what is required exactly.The alternative is to expose such
SetLevelfrom another package that is already public. However the current architecture doesn't offer a clear point in which this can be done.Fixes # (issue)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: