Fixed bug that allowed configs for Kafka listeners and advertised listeners to come out of sync #11068
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KafkaContainer
andConfluentKafkaContainer
both have a pair ofHashSet
properties:listeners
andadvertisedListeners
. At some point, these are being fed intoKafkaHelper.resolveListeners(GenericContainer<?>, Set<String>)
andKafkaHelper.resolveAdvertisedListeners(Set<Supplier<String>>)
to help generate values forKAFKA_LISTENERS
andKAFKA_ADVERTISED_LISTENERS
, respectively. Each registered listener will get assigned the protocolTC-<X>
where<X>
essentially is the index position of the listener in eachHashSet
, but sinceHashSet
doesn't guarantee any such order, a listener might be registered asTC-0
in theKAFKA_LISTENERS
env variable and asTC-1
inKAFKA_ADVERTISED_LISTENERS
.The least intrusive solution I could think of was to replace
HashSet
withLinkedHashSet
, which does guarantee insertion order, and should therefore work better with the way theKafkaHelper
methods are designed.