Skip to content

Put missing properties JdbcDatabaseContainer.createConnection #11371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ebyhr wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Put missing properties JdbcDatabaseContainer.createConnection #11371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ public Connection createConnection(String queryString, Properties info)
Properties properties = new Properties(info);
properties.put("user", this.getUsername());
properties.put("password", this.getPassword());
properties.putAll(info);
Copy link

@findinpath findinpath Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes little sense to have the properties constructed with info if we already add all its properties.

Copy link

@findinpath findinpath Dec 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix makes sense

public class TestProperties
{
    public static void main(String[] args)
    {
        Properties properties = new Properties();
        properties.setProperty("key1", "value1");
        properties.setProperty("key2", "value2");
        properties.forEach((k, v) -> System.out.println(k + ": " + v));

        System.out.println("--- After Copy ---");

        Properties newProperties  = new Properties(properties);
        newProperties.forEach((k, v) -> System.out.println(k + ": " + v));


        System.out.println("--- Defaults ---");
        System.out.println(newProperties.getProperty("key1"));
        System.out.println(newProperties.getProperty("unknown"));

    }
}

final String url = constructUrlForConnection(queryString);

final Driver jdbcDriverInstance = getJdbcDriverInstance();
Expand Down