Skip to content

feat(core): add enhanced wait strategies #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

terry-docker
Copy link
Contributor

  • Add HttpWaitStrategy for HTTP endpoint waiting with TLS, auth, headers support
  • Add HealthcheckWaitStrategy for Docker health check status monitoring
  • Add PortWaitStrategy for TCP port availability checking
  • Add FileExistsWaitStrategy for filesystem file existence waiting
  • Add CompositeWaitStrategy for combining multiple wait conditions
  • Include comprehensive unit tests for all new strategies
  • Enhanced error messages with actionable hints for debugging
  • Maintain backward compatibility with existing LogMessageWaitStrategy
  • Fix mypy type annotations for all new wait strategies

- Add HttpWaitStrategy for HTTP endpoint waiting with TLS, auth, headers support
- Add HealthcheckWaitStrategy for Docker health check status monitoring
- Add PortWaitStrategy for TCP port availability checking
- Add FileExistsWaitStrategy for filesystem file existence waiting
- Add CompositeWaitStrategy for combining multiple wait conditions
- Include comprehensive unit tests for all new strategies
- Enhanced error messages with actionable hints for debugging
- Maintain backward compatibility with existing LogMessageWaitStrategy
- Fix mypy type annotations for all new wait strategies
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 66.80328% with 81 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@003046b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/testcontainers/core/wait_strategies.py 66.80% 75 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage        ?   78.67%           
=======================================
  Files           ?       14           
  Lines           ?     1130           
  Branches        ?      172           
=======================================
  Hits            ?      889           
  Misses          ?      201           
  Partials        ?       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant