Skip to content

docs: use TS consistently in vitest instructions #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: use TS consistently in vitest instructions #660

wants to merge 1 commit into from

Conversation

s-h-a-d-o-w
Copy link

@s-h-a-d-o-w s-h-a-d-o-w commented Jan 11, 2025 •
edited
Loading

What:

Since you're currently mentioning "./vitest.setup.ts", I figured that you're fine with using TS and this change does so consistently. (And once that is done, it's no longer necessary to add the setup file to the includes.)

Why:

Instructions are currently inconsistent.

Checklist:

  • Documentation
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged

Bhavana104
Bhavana104 approved these changes Jan 24, 2025
View reviewed changes
Copy link

@Bhavana104 Bhavana104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Bhavana104 Bhavana104 Bhavana104 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s-h-a-d-o-w @Bhavana104