Point the dependency to WDK React Native Provider develop branch #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: replace custom mnemonic validation with bip39.validateMnemonic
Add address validation for existing networks
AndriianChestnykh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A better dev support for internal teams and community when there is a need to check features being still in development
Motivation and Context
Now we're collecting new breaking changes of Provider in it's develop branch.
So our team needs to change Starter's package.json locally
from this
"@tetherto/wdk-react-native-provider": "github:tetherto/wdk-react-native-provider#develop",to this
"@tetherto/wdk-react-native-provider": "^1.0.0-beta.3",Can we push the dep change into Starter's develop ? This will support both us and community, when they need check new features in develop
With this, when we are to merge develop into main in the future we