Allow door event flags for grey doors to work #247
Merged
+134
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I put in the door event options, I knew some of the grey doors didn't work, but it must have fallen off my radar. It wasn't that hard to make the doors work. These doors all have a flag set that stops processing in its tracks, which is a performance save (and important for certain doors). However removing that flag still causes the doors to be locked unless you can change the door flag, which you'd normally do by opening the door, but you can't do that for these grey doors because they have no clear condition (some grey doors have clear conditions like a boss dead or enemy count cleared, but you can set them to not have one). Thus removing the flag has no effect other than a minor performance hit, which is a good trade for the ability to go into the practice hack menu and have these doors be opened if desired.
I'm tempted to merge this in tonight. I am going to do a little more testing first; maybe it'll merge in tomorrow. Soon either way.