Fix syntax highlighting bugs in Squiffy editor (#170) #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two Ace editor highlighting issues:
1. @ commands after JavaScript blocks: Add a negative lookahead rule
to the JS embed exit rules that transitions back to the start state
when a line doesn't begin with indentation (tab or 4 spaces). This
ensures @ commands following JS blocks get proper highlighting.
2. Multiple Handlebars expressions on one line: Change the Handlebars
regex from greedy (.*) to non-greedy (.*?) so that each {{...}}
expression is matched individually instead of matching everything
between the first {{ and last }}.
https://claude.ai/code/session_01G218M1zXP9dDvVQ2U8n37d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two Ace editor highlighting issues:
@ commands after JavaScript blocks: Add a negative lookahead rule
to the JS embed exit rules that transitions back to the start state
when a line doesn't begin with indentation (tab or 4 spaces). This
ensures @ commands following JS blocks get proper highlighting.
Multiple Handlebars expressions on one line: Change the Handlebars
regex from greedy (.) to non-greedy (.?) so that each {{...}}
expression is matched individually instead of matching everything
between the first {{ and last }}.
https://claude.ai/code/session_01G218M1zXP9dDvVQ2U8n37d