parse JSON export akin to HTML export#11
parse JSON export akin to HTML export#11johanhoff wants to merge 6 commits intotextileio:masterfrom johanhoff:master
Conversation
|
Current quick-fix logs errors (last two lines of this log): |
|
The JSON should be parsed now, but I haven't looked into why the file is not downloading. I'll take a look later. |
johanhoff
left a comment
There was a problem hiding this comment.
Uncertain why file fails to download... need to debug now.
| else { | ||
| Textile.parseJson(zip); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Added switch in Textile.parseZip
| } | ||
| }); | ||
| return true | ||
| }, |
There was a problem hiding this comment.
Add reusable function called Textile.parseZipMap
⌛️Use Textile.parseZipMap in Textile.parseJson
⏳Reuse Textile.parseZipMap in Textile.parseHtml
There was a problem hiding this comment.
So we "Don't repeat ourselves", we could reuse our new parseZipMap function in parseHtml, but that may call for a separate pull request with separate testing.
You can accept this PR without a decision on this.
| Textile.addDownload(); | ||
| }); | ||
| }); | ||
| }, |
There was a problem hiding this comment.
⌛️Add new JSON functionality to Textile.parseJson
|
Okay "it works". When I unzip the download, I get this: However, I am ashamed to see now two things....
Constructive Feedback for TextileA pro tip for 2019In terms of organization, you get "the same thing" by:
The solution for 2020Well, I came to
Questions? |
|
Hey! Sorry for the delayed response. Awesome work + feedback. I'm thinking of adding a continuous exporter example that you can run on your desktop. I'll take what you learned here (2020) to help guide that for sure |

I'll try to parse JSON exports, as said in Issue #10.
This PR is now ready, pending tests and approval.
.parseZip.parseHtml.parseJson.parseZipMap.parseZipMapin.parseJson.parseZipMapin.parseHtml