Conversation
|
This code seems pretty unmaintained, is anyone actively monitoring for issues/PRs? @sorbits? |
|
@infininight ? Bueller? |
|
Hi, @miken32 I just forked this project at https://github.com/ondrejmirtes/php.tmbundle and merged your PR. I can do some of the features myself, but I'd like your help with adding union types from PHP 8 which aren't currently highlighted correctly. I'm doing this because GitHub itself uses php.tmbundle to highlight PHP code on the website with https://github.com/github/linguist. |
|
I moved on to PHPStorm, not using TM much any more since it's pretty stagnant. It's simple regex code, should be pretty easy to add union types. Good luck! @ondrejmirtes |
|
@ondrejmirtes for return type I think this is the line you'd need to alter: https://github.com/ondrejmirtes/php.tmbundle/blob/master/Syntaxes/PHP.plist#L1991 |
|
@ondrejmirtes I see they merged github-linguist/linguist#5677 pointing to your fork, but on Github diffs, the token Do you know if this is a case that was missed in your fork, or if it's something that got lost in the various steps between your fork -> linguist -> github web? |
|
@mkopinsky My fork only supports 8.0 features as the title states. If you send a PR for 8.1 features and beyond, I'm happy to merge it. |
|
I thought from the commit message that 7f704e6 would have covered it. I haven't tried to dive into the details of tmbundles to understand what's going on in that XML. Maybe some other time I'll try to dive in and do an 8.1 PR. |

This PR adds basic support for a number of features added in PHP versions 7.4 and 8.0. Resolves #84