Optimizations - fewer matrix multiplications, einsum, and optional noise#66
Open
jonaslb wants to merge 3 commits intotfrederiksen:masterfrom
Open
Optimizations - fewer matrix multiplications, einsum, and optional noise#66jonaslb wants to merge 3 commits intotfrederiksen:masterfrom
jonaslb wants to merge 3 commits intotfrederiksen:masterfrom
Conversation
Owner
|
Thanks a lot @jonaslb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of matrix multiplications quite significantly. It also introduces use of
np.einsuminstead of the custom function (it's still custom, but it uses einsum). Noise calculation was made optional.By a quick count I think the top part of
calcTracesthat is always executed goes from 19 to 14 matrix multiplications.It cannot be merged after #64 cleanly so depending on which is merged first, the other will need a rebase.