Fix missing assertion in EventBus test

[thalesraymond]

This commit addresses the SonarCloud issue AZveIAOQT-RotiMQfyHp in tests/EventBus.test.ts.

Problem:
The test case "should handle off when listener set exists but empty" executed eventBus.off("taskStart", callback); but lacked any explicit assertions to verify its outcome, violating the Sonar rule typescript:S2699 (Tests should include assertions).

Solution:
Wrapped the function call in an expect(() => { ... }).not.toThrow(); block. This asserts the expected behavior explicitly: attempting to remove a listener from an empty set does not throw an error.

All tests continue to pass.

---

PR created automatically by Jules for task 13809982669072939124 started by @thalesraymond

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of an existing test case by adding a crucial assertion. It ensures that a specific scenario involving the EventBus's off method behaves as expected without throwing errors, thereby resolving a SonarCloud quality gate issue and enhancing test reliability.

Highlights

• Test Assertion Fix: Addressed a SonarCloud issue by introducing an explicit assertion in tests/EventBus.test.ts to verify that calling eventBus.off on an empty listener set does not throw an error.
• SonarCloud Compliance: Resolved the typescript:S2699 rule violation (Tests should include assertions) by wrapping the eventBus.off call in an expect(() => { ... }).not.toThrow(); block.

Changelog

• tests/EventBus.test.ts
  • Added an expect().not.toThrow() assertion to a test case to verify the behavior of eventBus.off when attempting to remove a listener from an already empty set.

Activity

• PR created automatically by Jules for task 13809982669072939124, started by @thalesraymond.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an assertion to a test in tests/EventBus.test.ts. The change wraps a call to eventBus.off() within an expect().not.toThrow() block to satisfy a SonarCloud rule requiring assertions in tests. The test now explicitly checks that no error is thrown when attempting to remove a listener from an empty set.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!