Skip to content

fix: add readonly modifier to pluginManager in TaskRunner#209

Merged
thalesraymond merged 1 commit intomainfrom
fix/sonarcloud-readonly-pluginManager-5570201867908267440
Mar 18, 2026
Merged

fix: add readonly modifier to pluginManager in TaskRunner#209
thalesraymond merged 1 commit intomainfrom
fix/sonarcloud-readonly-pluginManager-5570201867908267440

Conversation

@thalesraymond
Copy link
Owner

This PR addresses a SonarCloud issue (AZxe9esREMd7o7qbmAWu) by enforcing immutability on the pluginManager private class field in TaskRunner.ts, which is only set in the constructor.


PR created automatically by Jules for task 5570201867908267440 started by @thalesraymond

Fixes SonarCloud code smell typescript:S3459 (Member 'pluginManager' is never reassigned; mark it as `readonly`.) in src/TaskRunner.ts by adding the `readonly` modifier.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a SonarCloud finding by applying the readonly modifier to the pluginManager field within the TaskRunner class. This change ensures that the pluginManager can only be assigned during object construction, thereby preventing accidental modification and enhancing the robustness and predictability of the class's internal state.

Highlights

  • SonarCloud Issue Resolution: Addressed SonarCloud issue AZxe9esREMd7o7qbmAWu by enforcing immutability on the pluginManager private class field in TaskRunner.ts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the readonly modifier to the pluginManager field in TaskRunner.ts, improving immutability as it's only assigned in the constructor. The change is beneficial. For consistency and to further enhance immutability, you could also consider making the eventBus and validator fields readonly as they follow the same pattern of being initialized only once.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thalesraymond thalesraymond merged commit 294db02 into main Mar 18, 2026
7 checks passed
@thalesraymond thalesraymond deleted the fix/sonarcloud-readonly-pluginManager-5570201867908267440 branch March 18, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant