Open
Conversation
thatmattlove
requested changes
Nov 11, 2022
Owner
thatmattlove
left a comment
thatmattlove
left a comment
There was a problem hiding this comment.
Can you add a type annotation for the icon_types function parameter? Should be merge ready after that!
Author
|
I am not too confident with Python's type annotation, but hopefully this helps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used this library with custom ICON_TYPES because I only wanted to generate only some of the favicon generated. Thought a pull request might help for the future!