Merged
Conversation
Collaborator
geovie
force-pushed
the
feat/generify-menu
branch
from
dd2e96d to
042e81b
Compare
Contributor
Author
|
Great, I removed the Signal and changed the MR to use v0.5 as base |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the time I found that I would want to use an enum for the MenuItem's, so this PR generifies Menu/MenuItem so that any type which satisfies Clone can be used as value.
Of course with the generics we hit leptos-rs/leptos#3200 (comment) so the type needs to be specified when creating the MenuItem's.
I wonder if
valueeven needs to be aSignalor if it could be a simple value?