feat: min and max props added to Grid#417
Conversation
thaw/src/grid/mod.rs
Outdated
| /// The min width of columns. | ||
| /// Defaults to "0px". | ||
| #[prop(into, default = "0px".into())] | ||
| min: MaybeProp<String>, |
There was a problem hiding this comment.
Is there any point in using MaybeProp instead of Signal here? Using the Signal type, we can ensure that min always has a value. (e.g. "0px")
There was a problem hiding this comment.
I agree with you, a Signal (with a default value) is better than a MaybeProp in this case. I have made the changes, see 16bf621.
thaw/src/grid/mod.rs
Outdated
| /// The max width of columns. | ||
| /// Defaults to "1fr". | ||
| #[prop(into, default = "1fr".into())] | ||
| max: MaybeProp<String>, |
There was a problem hiding this comment.
Is there any point in using MaybeProp instead of Signal here? Using the Signal type, we can ensure that max always has a value. (e.g. "1fr")
There was a problem hiding this comment.
I agree with you, a Signal (with a default value) is better than a MaybeProp in this case. I have made the changes, see 16bf621.
|
Thanks! The CI error was caused by |
* grid: added min and max props * switch from `MaybeProp`s to `Signal`s
* feat: min and max props added to Grid (#417) * grid: added min and max props * switch from `MaybeProp`s to `Signal`s * add input_size property to spin_button * i32 -> u32 --------- Co-authored-by: jerhat <2805041+jerhat@users.noreply.github.com>
2 participants
No description provided.