add input_size property to spin_button#426
Merged
lizidev merged 3 commits intothaw-ui:thaw/v0.5from Aug 1, 2025
kandrelczyk:feat/sping_button_size
Merged
add input_size property to spin_button#426lizidev merged 3 commits intothaw-ui:thaw/v0.5from kandrelczyk:feat/sping_button_size
lizidev merged 3 commits intothaw-ui:thaw/v0.5from
kandrelczyk:feat/sping_button_size
Conversation
* grid: added min and max props * switch from `MaybeProp`s to `Signal`s
lizidev
reviewed
Aug 1, 2025
thaw/src/spin_button/mod.rs
Outdated
| size: Signal<SpinButtonSize>, | ||
| /// Input size width. | ||
| #[prop(optional, into)] | ||
| input_size: Signal<Option<i32>>, |
Collaborator
There was a problem hiding this comment.
Change to u32 type. The specification requires:
This must be a valid non-negative integer greater than zero.
Contributor
Author
There was a problem hiding this comment.
For Input it's i32. Should I change it there as well?
Collaborator
There was a problem hiding this comment.
Yes, but changing the type of Input is a breaking change, so we can merge it into the thaw/v0.5 branch.
Contributor
Author
There was a problem hiding this comment.
Ok, I'm already using 0.5-beta so I will just change this PR to merge into 0.5 branch.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I'm missing this property. Hope it's fine to add.