Skip to content

[TVB-1999] Integrate Zenodo API #691

Open
abhi-glitchhg wants to merge 106 commits intomasterfrom
TVB-1999-deo
Open

[TVB-1999] Integrate Zenodo API #691
abhi-glitchhg wants to merge 106 commits intomasterfrom
TVB-1999-deo

Conversation

@abhi-glitchhg
Copy link
Copy Markdown
Collaborator

@abhi-glitchhg abhi-glitchhg commented Aug 23, 2023

No description provided.

abhi-glitchhg and others added 30 commits May 12, 2023 19:29
@abhi-glitchhg
Using pyzenodo3 as a client to connect with Zenodo.
b21d358
@abhi-glitchhg
remove the swp file from git, add .swp extension in gitignore
1f9ba1e
@abhi-glitchhg
remove the search related methods from zenodo class, currently we wil…
d3a869b 
…l just focus on the downloading functionality. If required searching functionalities can be added
@abhi-glitchhg
add method get_latest_version to fetch the latest version of the Re…
67331b8 
…cord
@abhi-glitchhg
add pooch as a dependancy
783aaea
@abhi-glitchhg
add tvb class and tests
198f0ef
@abhi-glitchhg
minor nits and fixes
80f3e3f
@abhi-glitchhg
added todo in fetch_data method
c906f19
@abhi-glitchhg
Update tvb_library/tvb/datasets/tvb_data.py
faaec3b
@abhi-glitchhg
fixed the absolute path error
a3e060a
@abhi-glitchhg
added header
ae10817
@abhi-glitchhg
added header
c57ed91
@abhi-glitchhg
added DATASETS_FOLDER attribute to config settings.
2d7ebdc
@abhi-glitchhg
some improvements in tests, now from_cls method of connectivity loads…
cd536af 
… data using new method
@abhi-glitchhg
Merge branch 'pyzenodo' of https://github.com/abhi-glitchhg/tvb-root …
cb7c838 
…into pyzenodo
@abhi-glitchhg
fix typos
96e87cb
@abhi-glitchhg
extract dir parameter when instantiating the class.
1af4cb7
@abhi-glitchhg
change download_dir to .cache/tvb from .cache/pooch
2d2188c
@abhi-glitchhg
.
d9a14f3
@abhi-glitchhg
Merge pull request #675 from abhi-glitchhg/pyzenodo
ace365f 
merging to check if ci is happy and green.
@abhi-glitchhg
fixed the file not found errors with remaining datatypes'
51a2f9c
@abhi-glitchhg
add types
d651659
@abhi-glitchhg
Merge pull request #676 from abhi-glitchhg/pyzenodo
597d249
@abhi-glitchhg
removed the data setup from build.yml, fix the errors found in tests
a04b6d9
@abhi-glitchhg
Merge pull request #677 from abhi-glitchhg/pyzenodo
324548f 
Fixing the dataloading for "edited_connectivity"
@abhi-glitchhg
replacing tvb_data package from code.
7eadc0b
@abhi-glitchhg
Merge branch 'TVB-1999-deo' into pyzenodo
3776c0e
@abhi-glitchhg
Merge pull request #678 from abhi-glitchhg/pyzenodo
6b8a310 
removing tvb_data library dependency
@abhi-glitchhg
fix tvb_data not found error and one identation error
bf2148e
@abhi-glitchhg
Merge branch 'pyzenodo' of https://github.com/abhi-glitchhg/tvb-root …
792218b 
…into pyzenodo
abhi-glitchhg and others added 18 commits July 26, 2023 22:32
@abhi-glitchhg
add missing : to the github workflow files.
f639109 
:)
@abhi-glitchhg
fixed the silly indentation mistakes in the github actions files.
7c328f9
@abhi-glitchhg
fix the directory path in the tests
a8b5f70
@abhi-glitchhg
add line which was removed accidentally while resolving the conflict
c63a507
@abhi-glitchhg
resolve the conflicts
c73ac6b
@abhi-glitchhg
typo fix
f6e2e99
@abhi-glitchhg
api change and fix typo
02a31b4
@abhi-glitchhg
getting missing whitespace around operator error
ffbe985
@abhi-glitchhg
revert the change
0918d35
@abhi-glitchhg
fix the pycodestyle issue
842e764
@abhi-glitchhg
Merge branch 'master' into pyzenodo
033ec3c
@abhi-glitchhg
Merge pull request #687 from abhi-glitchhg/pyzenodo
bd99ddc 
Fix the indentation mistakes for workflow files in TVB-1999-deo branch
@abhi-glitchhg
minor changes
294a4d8
@abhi-glitchhg
Merge branch 'pyzenodo' of https://github.com/abhi-glitchhg/tvb-root …
f7f7765 
…into pyzenodo
@abhi-glitchhg
fix test fix
6bef087
@abhi-glitchhg
Merge branch 'the-virtual-brain:master' into pyzenodo
59bf03f
@abhi-glitchhg
Merge branch 'the-virtual-brain:master' into pyzenodo
b54440f
@abhi-glitchhg
Merge pull request #690 from abhi-glitchhg/pyzenodo
0e7424e 
Update TVB-1999-deo branch
@liadomide liadomide mentioned this pull request Aug 23, 2023
Closed
@abhi-glitchhg abhi-glitchhg changed the title [TVB-1990] Integrate Zenodo API [TVB-1999] Integrate Zenodo API Aug 26, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

86.1% 86.1% Coverage
0.0% 0.0% Duplication

@maedoc maedoc mentioned this pull request May 30, 2024
Closed
@liadomide
Copy link
Copy Markdown
Member

liadomide commented May 30, 2024

We would need here:

  • a good review of the code changed
  • fixing conflicts (maybe with a rebase?)
  • evaluate if performance is ok after these changes (e.g. no drop in perf for running all tests)
  • is the new API clear enough ?
  • if all good, them merge

@abhi-glitchhg
Copy link
Copy Markdown
Collaborator Author

abhi-glitchhg commented Jun 8, 2024

Hey lia,

let me know if you need any help from my side. I would be happy to help.

😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romina1601 romina1601 Awaiting requested review from romina1601

@AdrianValentinCiu AdrianValentinCiu Awaiting requested review from AdrianValentinCiu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhi-glitchhg @liadomide