clean up GetCGameAPI #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do it. other than this function, there's no further connection between engine, mod, and QMM related to CGame. the mod dll path-detecting code could better match s_main_load_mod but it's ok for now since it's just Q2R. i did add the debug messagebox code to GetCGameAPI, however.
thecybermind
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looked through the code paths. this might just be the simplest way to do it. other than this function, there's no further connection between engine, mod, and QMM related to CGame. the mod dll path-detecting code could better match s_main_load_mod but it's ok for now since it's just Q2R. i did add the debug messagebox code to GetCGameAPI, however.