Dev issue2 #5
Merged
Dev issue2 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerating entstring to provide extra info in stripper_dump - GAME_JASP: properly handle -1 arg to G_SET_ACTIVE_SUBBSP - GAME_JAMP: add code to G_SET_ACTIVE_SUBBSP post hook to pull all new entities from engine, and store in a list (specific to the subbsp index) - GAME_JAMP: add code to G_GET_ENTITY_TOKEN to handle reading from specific subbsp list if necessary - GAME_JAMP: add GAME_INIT post hook to add "_subbsp_index=index" keyval to each subbsp entity and then add to g_mapents/g_modents - still todo: fix statics/state in ent_next_token() to handle swapping to a different list mid-way
…s. it will take entities from an entstring or G_GET_ENTITY_TOKEN, and can output tokens (for use in G_GET_ENTITY_TOKEN hook to pass to mod) or entstring (for SpawnEntities functions). this class also provides a lot of the other ent_* function functionality. stripper_qmm also can now properly handle and filter JAMP subbsp entries, and a lot of duplicate code between it and the JASP subbsp solution was removed. the only thing i still need to do is have the stripper_dump command also print the subbsps if JAMP/JASP
…initialize iterator after the object was copied into the subbsp containers, so needed to rule-of-5 the MapEntities class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle misc_bsp entities and subbsp loading in JAMP. This also required a hefty code change in the entity storage system which affected all the other games as well, including JASP. Tested subbsp support with both JA games on Windows.