⚡ Optimize clean_video_url by lifting import#4
Conversation
Co-authored-by: thedeutschmark <7561855+thedeutschmark@users.noreply.github.com>
Co-authored-by: thedeutschmark <7561855+thedeutschmark@users.noreply.github.com>
…ne-3810051636282598218
…13215734381991226107
Extracted the expensive yt-dlp validation logic into a helper function `_get_video_info` decorated with `@functools.lru_cache`. - Only successful validation results are cached. - Failures raise an exception (which is not cached), allowing for retries. - Verified with a benchmark showing reduction from ~0.5s to ~0.001s for repeated calls. Co-authored-by: thedeutschmark <7561855+thedeutschmark@users.noreply.github.com>
…79caafe ⚡ Optimize validate_url with result caching
Co-authored-by: thedeutschmark <7561855+thedeutschmark@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ying. Co-authored-by: thedeutschmark <7561855+thedeutschmark@users.noreply.github.com>
… logo - Removed iPhone-style filmstrip trimmer, replaced with simple range sliders - Restructured workflow: Step 1 validates+downloads, Step 2 is options, Step 3 is crop/trim - Added local video file upload with drag-and-drop support - Implemented animated exclamation marks in logo (only animate during loading) - Added volume slider to video preview - Made video preview float alongside workflow (sticky sidebar) - Fixed crop overlay dragging and display issues - Added responsive layout for better screen utilization - Removed deutschmark branding, simplified to "Alert! Alert!" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…59542003802542 ⚡ Optimize get_env with lru_cache
Keep both functools and urllib.parse imports at top level. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
TODO: add automatic dependency downloader that doesn't break any laws |
Acknowledged. This is out of scope for the current performance optimization task, but I'll keep it in mind for future improvements. |
Co-authored-by: thedeutschmark <7561855+thedeutschmark@users.noreply.github.com>
1 participant
from urllib.parse import urlparse, parse_qsfrom insideclean_video_urlto the module level.requirements.txtwhich contained null bytes in thewaitressline, causingpip installto fail.PR created automatically by Jules for task 10750436348059615491 started by @thedeutschmark