Draft
Conversation
thedogecraft
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Dashboard page and replaces it with
homewhich simply tells user to go to other pages.Why
The
systeminformationpackage was being called on the dashboard page to display system info. under the hood, it was causing CPU spikes and load times of up to 5 minutes for some users on low end PCs before that page was usable. And the whole point of sparkle is to debloat and optimize your Windows PC.I've been considering introducing another programming language to help with these tasks such as C# or go, but at the moment I am unsure.
Changes
Home.tsx,system.tsWhat I Did Not Change
I have decided to not remove the
systeminfomationpackage at this time since Sparkles GPU detection feature relies on this package, For your information, Sparkle uses this for allow or dissallowing users to apply thinks like HAGS or NVIDIA Tweaks. Like I said earlier I may introduce another language to help with these tasks and keep the Electron part lightweight and only for the gui.This may return in the future. And I'm not sure if I want to merge this.