Drop 'Using TFTP services through NAT' procedure #3852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both the "Enabling connections from a client to {ProjectServer}" and
"Enabling connections from {ProjectServer} and clients to a
{SmartProxyServer}" procedures there is a --add-service=tftp line so
users are already told to open up port 69 from clients.
Then the specific part of allowing it through NAT is not something we
support anywhere.
github-actions
bot
added
Needs tech review
10 tasks
aneta-petrova
added
style review done
Member
|
Style-wise no issues and there is nothing to test. I'm still not sure what to do for tech review in these cases. On one hand, it would be good to get a second opinion to confirm that the procedure is indeed undesirable to keep, on the other hand, when it's a writer submitting a PR, we only require one engineer's opinion for tech review, not two. |
Member
Author
|
@evgeni could you have a look? |
evgeni
approved these changes
May 12, 2025
Member
|
I like diffs with negative line counts, so am happy to provide my ACK here :) |
maximiliankolb
approved these changes
May 12, 2025
maximiliankolb
added
tech review done
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
In both the "Enabling connections from a client to {ProjectServer}" and "Enabling connections from {ProjectServer} and clients to a {SmartProxyServer}" procedures there is a --add-service=tftp line so users are already told to open up port 69 from clients.
Then the specific part of allowing it through NAT is not something we support anywhere.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
This came up because of https://github.com/theforeman/foreman-documentation/pull/3851/files#r2083388803, but already in #3530 and #3839 I looked at the content and had my questions about it.
Checklists
Please cherry-pick my commits into: