Allow bootstrapping foreman-build #12768
Open
+37
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This may be an effect of the conditionals I use. Needs some further investigation. This is allowed in RPM 4.20+ but I guess the version used here is older: |
Member
|
The two warnings we see are caused by We could modify that changelog entry to dismiss the warnings. To fix the errors, we either need to upgrade the RPM or we put that comment on the line above or below the conditional. Is there any other way? |
ekohl
force-pushed
the
rpm/develop-bootstap-foreman
branch
from
cd8fd32 to
999ea95
Compare
Member
Author
|
Rebased to clean the rpmlint warning and also changed the endif statements to be compatible with EL9 RPM. |
ekohl
force-pushed
the
rpm/develop-bootstap-foreman
branch
from
999ea95 to
a547aa5
Compare
Member
Author
|
Edit: it's back; I messed up the original changelog entry but that's fixed now. |
ekohl
force-pushed
the
rpm/develop-bootstap-foreman
branch
from
a547aa5 to
80644ed
Compare
ekohl
force-pushed
the
rpm/develop-bootstap-foreman
branch
from
80644ed to
4db1a52
Compare
In a fresh environment you need the foreman-build package, but you can't build that without foreman itself. This uses RPM conditionals[1] to only build the foreman-build and foreman-plugin packages. It moves the macro definition next to the mkdir statement to have fewer if statements. [1]: https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html
This introduces a single variable to configure the buildroot as either
bootstrapping or not.
Recommended way of using it:
obal copr-project foreman-copr -e bootstrap=true
obal release foreman
obal copr-project foreman-copr
Then build all the required packages.
ekohl
force-pushed
the
rpm/develop-bootstap-foreman
branch
from
4db1a52 to
524a24c
Compare
Member
|
How did a build from this PR end up in the staging repo?! in the changelog |
Member
Author
|
Because I messed up a command and my user has the permissions. I deleted the copr build, will see about nightly too. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a fresh environment you need the foreman-build package, but you can't build that without foreman itself. This uses RPM conditionals to only build the foreman-build and foreman-plugin packages.
It moves the macro definition next to the mkdir statement to have fewer if statements.
To use this you need to define the with option at the chroot level. I've opened theforeman/obal#419 for that and working on the end-to-end pieces. Once that's merged you can use:
This is useful if you want to fully bootstrap it from scratch in your own user. It can also be used to start building a new OS (version) or architecture but then it needs some manual tweaking.