Fixes #38601 - replace react-ellipsis-with-tooltip #10620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
force-pushed
the
remove-react-ellipsis-with-tooltip
branch
from
707ed40 to
ac20e69
Compare
Member
Is it me or are the screenshots in the other order (after & before)? Personal opinion: I prefer the black version. If it gets rid of a dependency that's even better :) |
This was referenced Jul 22, 2025
Member
Author
yes which why i specified the colors in case they are out of order :) |
Member
Author
|
These + plugin PRs that I opened are all that I found https://github.com/search?q=org%3Atheforeman+OR+org%3Akatello+react-ellipsis-with-tooltip&type=code |
MariaAga
force-pushed
the
remove-react-ellipsis-with-tooltip
branch
2 times, most recently
from
1c13ea4 to
b6803de
Compare
ekohl
reviewed
Jul 22, 2025
MariaAga
force-pushed
the
remove-react-ellipsis-with-tooltip
branch
from
b6803de to
20c31dc
Compare
Member
Author
|
All plugins are merged |
evgeni
reviewed
Jul 22, 2025
| "react-dnd": "^14.0.2", | ||
| "react-dom": "^16.8.1", | ||
| "react-bootstrap": "^0.32.0", | ||
| "react-ellipsis-with-tooltip": "^1.0.8", |
Member
There was a problem hiding this comment.
Does that mean we can also drop react-bootstrap, or shall we keep that to a separate PR, not to entangle too many things?
evgeni
approved these changes
Jul 22, 2025
Member
|
Packaging: theforeman/foreman-packaging#12276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since this removes the package its best to first merge the (unopened katello and templates prs)
before (grey) & after (black)