Replace pkg_resources with importlib for Python 3.12+ support #411
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
This patch will allow running on Python > 3.11. |
|
All test failures seem to be unrelated. I've filed #412 for one of the failures I've spotted. |
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Looks good. I don't consider the docs config to be blocking and I need this on my own dev setup so merging this.
| package = pkg_resources.require("obal")[0] | ||
| version = package.version | ||
| release = package.version | ||
| from importlib import metadata |
There was a problem hiding this comment.
Note to self: added in Python 3.8 (https://docs.python.org/3/library/importlib.metadata.html#module-importlib.metadata)
| release = package.version | ||
| from importlib import metadata | ||
| version = release = metadata.version('obal') | ||
| except: |
There was a problem hiding this comment.
Shall we scope it explicitly to metadata.PackageNotFoundError now?
I'd be tempted to use
from importlib import metadata
try:
version = release = metadata.version('obal')
except metadata.PackageNotFoundError:
version = release = ''There was a problem hiding this comment.
I'll check this one out
|
|
||
| import os | ||
| import obsah | ||
| from importlib import resources |
There was a problem hiding this comment.
Note to self: added in Python 3.7 (https://docs.python.org/3/library/importlib.resources.html#module-importlib.resources)
| # https://github.com/pytest-dev/pytest-xdist/issues/414 | ||
| distribution = pkg_resources.get_distribution('obal') | ||
| path = os.path.join(distribution.location, path) | ||
| path = str(resources.files(__name__) / 'data') |
There was a problem hiding this comment.
Note to self: added in Python 3.9 (https://docs.python.org/3/library/importlib.resources.html#importlib.resources.files). This call looks correct for both 3.9 and 3.12+ (where it was changed).
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Would you mind rebasing this and also update the README that we require Python 3.9+?
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Merging despite failing CI. That's introduced by https://docs.ansible.com/projects/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#example-implicit-boolean-conversion and tracked in #412.
2 participants
Summary
• Replace deprecated pkg_resources with modern importlib
• Fix Python 3.12+ compatibility issues
• Update shebang from python2 to python3
Fixes #405
🤖 Generated with Claude Code