Use foreman-proxy certs instead of Puppet certs as default #106
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ekohl Do you mind taking a short look as you have also reviewed theforeman/foreman-documentation#3896 ? |
Contributor
Author
|
I think tests will turn green once theforeman/smart-proxy#914 is merged. |
Contributor
Author
|
Did not fix all the tests, so we need to have this one to fix the CI: #107 |
nadjaheitmann
force-pushed
the
update_certs_default_values
branch
from
2b31f32 to
17bc465
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that it would be the better option to write those values directly from the installer, but I am looking for a quick fix to remove the Puppet dependency from here. Any clean and installer-based implementation I would consider a follow-up.