Entity permission overrides #2201
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ok, I'm looking now. |
Owner
|
I'm not really sure what the use case of this is vs just adding a friend to your prop protection permissions, or using the prop permission tool that FPP has or whatever. I feel like this belongs in the prop protection addon instead of starfall. |
Owner
|
I guess it might be useful to make an entity not do permission checks to save CPU time, but the issue is that a prop's owner/permissions could change, and then the starfall that has permission will continue to have permission. |
Owner
|
I have an idea that could make this work better, but I'll need to do some work on entity permission first. |
Owner
|
If you can integrate the override functionality with the new cache type, then I'll look again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for Starfall instances to grant permission overrides to specific Starfall instances. The idea being that you can call entityYouOwn:grantPermission(starfall, "permission") to grant an entity-related permission to another Starfall instance programmatically, without having to give that player full CPPI permissions/permissions for every single entity.
I have NOT fully tested this yet, but I will - I just want a review of this before I test things out (and maybe a second pair of eyes in testing, since this messes with permissions logic)