Skip to content

Fix setBoneMatrix error #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thegrb93 merged 2 commits into from
Dec 24, 2025
Merged

Fix setBoneMatrix error #2227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe78d36
Add isBoneWriteable and fix error
thegrb93 Dec 24, 2025
6e1843b
Revert
thegrb93 Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lua/starfall/libs_sh/entities.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,6 @@ function ents_methods:setBoneMatrix(bone, matrix)
checkpermission(instance, ent, "entities.setRenderProperty")

bone = math.Clamp(math.floor(bone), 0, Ent_GetBoneCount(ent)-1)
if Ent_GetBoneName(ent, bone) == "__INVALIDBONE__" then SF.Throw("Invalid Bone! "..bone, 2) end

local ent_tbl = Ent_GetTable(ent)
local boneTbl = ent_tbl.SF_BoneMatrix
Expand All @@ -1266,7 +1265,7 @@ function ents_methods:setBoneMatrix(bone, matrix)
ent_tbl.SF_BoneMatrix = boneTbl
ent:AddCallback("BuildBonePositions", function(ent, bonecount)
for i=0, bonecount-1 do
if boneTbl[i] then Ent_SetBoneMatrix(ent, i, boneTbl[i]) end
if boneTbl[i] and Ent_GetBoneName(ent, i) ~= "__INVALIDBONE__" then Ent_SetBoneMatrix(ent, i, boneTbl[i]) end
end
end)
end
Expand Down