Skip to content

Conversation

@x-xiang
Copy link

@x-xiang x-xiang commented Oct 14, 2025

When reusing a tmux session on a remote machine, the SSH_TTY environment variable may not be accurate, because it only represents the TTY when the tmux session was first created. When the tmux session is later reattached, the TTY may be different, especially when multiple users are sharing the same remote machine.

@theimpostor
Copy link
Owner

Can we fix these static checks:

main.go:98:16: ST1005: error strings should not be capitalized (staticcheck)
                        return nil, fmt.Errorf("Failed to open file %v: %v", logfileFlag, err)
                                    ^
main.go:125:11: ST1005: error strings should not be capitalized (staticcheck)
                        return fmt.Errorf("Failed to lookup terminfo: %w", err)
                               ^
main.go:189:11: ST1005: error strings should not be capitalized (staticcheck)
                        return fmt.Errorf("Error running 'tmux show -gwsv allow-passthrough': %w", err)
                               ^
3 issues:
* staticcheck: 3

Other than that looks good.

@x-xiang
Copy link
Author

x-xiang commented Oct 18, 2025

Can we fix these static checks:

main.go:98:16: ST1005: error strings should not be capitalized (staticcheck)
                        return nil, fmt.Errorf("Failed to open file %v: %v", logfileFlag, err)
                                    ^
main.go:125:11: ST1005: error strings should not be capitalized (staticcheck)
                        return fmt.Errorf("Failed to lookup terminfo: %w", err)
                               ^
main.go:189:11: ST1005: error strings should not be capitalized (staticcheck)
                        return fmt.Errorf("Error running 'tmux show -gwsv allow-passthrough': %w", err)
                               ^
3 issues:
* staticcheck: 3

Other than that looks good.

I originally used lowercase, but I saw uppercase being used elsewhere and switched to uppercase to be consistent. Now, I've change them all to lowercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants