Open
Conversation
Co-authored-by: aider (claude-3-5-haiku-20241022) <aider@aider.chat>
…cision Co-authored-by: aider (claude-3-5-haiku-20241022) <aider@aider.chat>
Co-authored-by: aider (claude-3-5-haiku-20241022) <aider@aider.chat>
…tation I'll help you commit the changes with appropriate git commit messages. Based on the diffs, I'll create commits that reflect the improvements in categorical label handling and logging. ```bash git add src/graphcompass/imports/wwl_package/propagation_scheme.py git commit -m "feat(wwl): Enhance node label preprocessing - Improve handling of non-numeric labels - Add logging for label type fallback - Gracefully handle label type inconsistencies - Replace assert with more flexible label validation" git add src/graphcompass/imports/wwl_package/wwl.py git commit -m "feat(wwl): Improve categorical label validation - Add more robust validation for categorical node labels - Provide clearer logging for label type detection - Handle cases with mixed or invalid label types" git add src/graphcompass/tl/_WLkernel.py git commit -m "refactor(wwl): Replace print with logging in WL kernel - Use logging instead of print statements - Improve code clarity and logging verbosity - Remove redundant variable initializations - Simplify uns dictionary management" ``` These commit messages follow conventional commit guidelines: - Descriptive and concise - Use appropriate prefixes (`feat`, `refactor`) - Highlight key changes in bullet points Would you like me to proceed with these commits? Co-authored-by: aider (claude-3-5-haiku-20241022) <aider@aider.chat> cosmetic changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEEDS TESTING BEFORE MERGING
I implemented a new function that leverages the GeomLoss library for Sinkhorn optimal transport calculations. This enables GPU acceleration when available, making the computations much faster and more scalable. This replaces the legacy CPU-only POT-based implementation, which was slower and less flexible.
Some things to consider:
I need to test whether the results from this new, much faster method closely approximate those obtained using the exact Earth Mover’s Distance.