Merged
Conversation
Collaborator
|
Hey @DinhLongHuynh , thank you so much for the contribution! I will test it and happily merge asap if there are no problems |
VladimirShitov
approved these changes
Aug 6, 2025
Collaborator
VladimirShitov
left a comment
There was a problem hiding this comment.
Thank you, looks great! I simplified the code a bit, but it should yield the same result. I've also added a test case with an empty paper list in telegram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty DataFrame Handling Issue in ArticlesProcessor
Problem Overview
When no papers are found on a specific day, the search returns an empty list, which gets converted to an empty DataFrame in the
ArticlesProcessorclass. This causes errors in all processing methods because they assume the DataFrame has the expected structure and columns.Error Flow
articles = []pd.DataFrame.from_dict([])creates DataFrame with no columnsSpecific Errors
"None of [Index(['databases', 'publication_date', 'title', 'keywords', 'url'], dtype='object')] are in the [columns]"'Series' object has no attribute 'apply'Root Cause
Solution
Add validation layer in each
ArticlesProcessorfunction to:This ensures robust and reliable operation even when no papers are found.