refactor: add example env file for easier environment variable management#685
Open
Kat-Alo wants to merge 5 commits intothemarshallproject:developfrom
Open
refactor: add example env file for easier environment variable management#685Kat-Alo wants to merge 5 commits intothemarshallproject:developfrom
Kat-Alo wants to merge 5 commits intothemarshallproject:developfrom
Conversation
Kat-Alo
commented
Sep 5, 2023
.devcontainer/docker-compose.yml
Outdated
|
|
||
| # Use "forwardPorts" in **devcontainer.json** to forward an app port locally. | ||
| # (Adding the "ports" property to this file will not forward from a Codespace.) | ||
| env_file: |
Author
There was a problem hiding this comment.
I can't honestly say I know how I mangled the git history here, but the diff should only be the switch from using environment variables to an env file like shown in this duplicate (and now closed) PR.
Author
There was a problem hiding this comment.
Ahhh, I see now. Y'all purged docker files on develop. I can definitely just nix this file, but thinking more about how this impacts the PRs we have in the queue... 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is purely meant as a developer experience enhancement. Rather than referencing different environment variables in different files, it can sometimes be a bit easier to copy the contents of an example env file into an actual env file and go from there.
Worth noting: this is part of my team's effort to sort out our guidelines for contributing back to open source projects we stand up for The Post's newsroom. This is just a small test case for our first go at it with Klaxon.