Large record deletion timeout fix, fixes #699#702
Open
Kat-Alo wants to merge 3 commits intothemarshallproject:mainfrom
Open
Large record deletion timeout fix, fixes #699#702Kat-Alo wants to merge 3 commits intothemarshallproject:mainfrom
Kat-Alo wants to merge 3 commits intothemarshallproject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gem that allows for a faster deletion of child records (page snapshots) when deleting a parent record (page). This problem was leading to timeouts when trying to delete pages that had many snapshots, and the makers of the gem seem to capture the problem well in this post.
This change does cause one test to fail (
deletes associated snapshots and changes upon deletion), but given that RoR is not my forte, I left the test unchanged.