Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of critical issues identified after an audit of the code base of the FFprime project.
1. Security & Reliability
get_popenutility of the fileffprime/utils/write.py.shlexlibrary has been integrated to safely parse the commands passed as strings.2. Functional Bug Fixes
numpyhas been added to the fileffprime/utils/seminario.py.qa/qbinstead of the incorrectq1/q2to match the arguments.compute_electrostatic_energy_with_cphas been corrected to use thealphaparameter dictionary instead of the undefined variableref_a.len(sa)instead of the irrelevantlen(c6a)to compute the dispersion/repulsion energy.